get stake interface in solidity #955
Conversation
open-junius
changed the title
open-junius
changed the title
|
|
Please implement the e2e test for this as a separate test and let it fail. When we merge to devnet-ready, the tests will be passing. |
|
https://github.com/opentensor/subtensor-js-tests/blob/main/src/evm/eth.staking.precompile.test.js#L215 separate test case is added. |
|
It would be great to have this merged ! Thanks for this PR. |
sam0x17
added
the
skip-cargo-audit
| * @param coldkey The coldkey public key (32 bytes). | ||
| * @return The current stake amount in uint64 format. | ||
| */ | ||
| function getStake(bytes32 hotkey, bytes32 coldkey) external view returns (uint64); |
There was a problem hiding this comment.
| function getStake(bytes32 hotkey, bytes32 coldkey) external view returns (uint64); | |
| function getStake(bytes32 hotkey, bytes32 coldkey, uint16 netuid) external view returns (uint64); |
| * It is a view function, meaning it does not modify the state of the contract and is free to call. | ||
| * | ||
| * @param hotkey The hotkey public key (32 bytes). | ||
| * @param coldkey The coldkey public key (32 bytes). |
There was a problem hiding this comment.
| * @param coldkey The coldkey public key (32 bytes). | |
| * @param coldkey The coldkey public key (32 bytes). | |
| * @param netuid The subnet the stake is on (uint16). |
| @@ -59,6 +59,9 @@ impl StakingPrecompile { | |||
| id if id == get_method_id("removeStake(bytes32,uint256,uint16)") => { | |||
| Self::remove_stake(handle, &method_input) | |||
| } | |||
| id if id == get_method_id("getStake(bytes32,bytes32)") => { | |||
There was a problem hiding this comment.
| id if id == get_method_id("getStake(bytes32,bytes32)") => { | |
| id if id == get_method_id("getStake(bytes32,bytes32,uint16)") => { |
|
Needs the |
Will update it after RAO feature merged. Now, we can use the netuid in nowhere. |
Description
The PR add the stake data access in solidity precompile contract.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.